Set Views used for CarouselView to Match Parent #21662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
previously approved these changes
Apr 5, 2024
…s tries to fill the container
PureWeen
changed the title
mattleibow
previously approved these changes
Apr 5, 2024
|
Failing tests unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This "regressed" from #18856 because the code that was removed was causing an infinite layout loop that would basically cause the resize to happen. My guess is that, at some point in XF the "UpdateContentLayout" code was added to resolve this issue because things weren't remeasuring. So, we added a bunch of measuring/arranging inside the Layout call on
ItemContentViewto make up for this.This change modifies the views used for CarouselView so that they are set to match_parent. Setting the layout parameters to match_parent appears to trigger the proper measure/layout path when the orientation/size changes.
I tested this against the original recipes issue as well and it fixed that scenario as well.
I tested various CarV scenarios that we have in our gallery as well to make sure peaking and spacing and things all work alright.
Issues Fixed
Fixes #21609
Fixes #21401