Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the templates #2264

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Build the templates #2264

merged 5 commits into from
Aug 25, 2021

Conversation

mattleibow
Copy link
Member

Description of Change

Making sure we aren't breaking the templates. Still not perfect as we don't have a way to build Windows using local workloads.

Additions made

  • Added a job to build the templates

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@mattleibow mattleibow added this to the 6.0.100-rc.1 milestone Aug 25, 2021
@mattleibow mattleibow requested a review from Eilon as a code owner August 25, 2021 21:02
@mattleibow mattleibow merged commit 4392fd6 into main Aug 25, 2021
@mattleibow mattleibow deleted the dev/build-templates branch August 25, 2021 22:51
@Eilon Eilon added the area-templates Project templates, Item Templates for Blazor and MAUI label Sep 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@samhouts samhouts added the fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-templates Project templates, Item Templates for Blazor and MAUI fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants