Templates exclude windows tfm #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Aug 30, 2021
|
So this is hopefully temporary, right? This is sad |
Eilon
approved these changes
Aug 30, 2021
|
Yeah, I think we are just waiting for the new Windows App SDK workload to reach VS. |
Eilon
added
the
area-templates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are moving to a true single project, windows is now a TFM in the main single project by default, yay!
However, we are currently going to comment out the inclusion of this TFM to make it an explicit opt-in from the templates. This is due to the upcoming preview of VS2022 not including all of the necessary Windows SDK and extension bits in the installer.
The problem is, if you don't know to install more components in VS, you will not be able to build for any TFM in a new MAUI project.
The line can be easily commented out once the developer is ready to include the TFM in their project.