Rename old Xamarin -> MAUI android resource/provider #4211
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want this content provider to clash with the older essentials one, so renaming, along with the relevant resource.
src/Essentials/src/OrientationSensor/OrientationSensor.ios.watchos.cs
Outdated
Show resolved
Hide resolved
src/Essentials/src/OrientationSensor/OrientationSensor.ios.watchos.cs
Outdated
Show resolved
Hide resolved
src/Essentials/src/OrientationSensor/OrientationSensor.ios.watchos.cs
Outdated
Show resolved
Hide resolved
jamesmontemagno
approved these changes
Jan 19, 2022
|
@Redth all of this also references Xamarin.Essentials -> https://github.com/dotnet/maui/tree/main/src/Essentials/docs/ |
|
@jamesmontemagno yep, API docs are being worked on for MAUI right now, and we'll apply the same process to Essentials once it's ready. |
|
@Redth lovely! <3 |
mattleibow
approved these changes
Jan 19, 2022
|
From ->#4192 (comment) there are some other areas references xamarinessentialslike securestorage @Redth |
hartez
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want this content provider to clash with the older essentials one, so renaming, along with the relevant resource.
Fixes #4192