-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Essentials.WebAuthenticator refactored to interface and singleton #4757
Merged
Redth
merged 12 commits into
dotnet:main
from
Forks4Work-Microsoft-Xamarin:essentials-interfaces-webauthenticator
Feb 24, 2022
Merged
Essentials.WebAuthenticator refactored to interface and singleton #4757
Redth
merged 12 commits into
dotnet:main
from
Forks4Work-Microsoft-Xamarin:essentials-interfaces-webauthenticator
Feb 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-essentials
Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info
label
Feb 18, 2022
We used to call the selector manually here when we needed backwards compat in forms with a really old version of VS (2017?). This is no longer necessary.
Redth
reviewed
Feb 19, 2022
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
reviewed
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice!
Comment on lines
14
to
33
=> PlatformAuthenticateAsync(new WebAuthenticatorOptions { Url = url, CallbackUrl = callbackUrl }); | ||
=> Current.AuthenticateAsync(new WebAuthenticatorOptions { Url = url, CallbackUrl = callbackUrl }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this new things? Don't we have this 2 param api on the interface now?
mattleibow
approved these changes
Feb 24, 2022
37 tasks
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Look for this fix in 6.0.200-preview.14.2!
label
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-essentials
Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info
fixed-in-6.0.200-preview.14.2
Look for this fix in 6.0.200-preview.14.2!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implements #
Additions made
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.