Enable File Picker in Blazor Android WebView #4928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables selecting files within the Blazor WebView (includes both `<InputFile />` and `<input type="file">`). The Blazor Android WebView was updated to utilize the [MAUI Essentials File Picker API](https://docs.microsoft.com/en-us/xamarin/essentials/file-picker?context=xamarin%2Fandroid&tabs=android). Thanks @mattleibow for the tip! Note, you'll need to add the `READ_EXTERNAL_STORAGE` permission to your `AndroidManifest.xml`: ```xml <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" /> ``` or update the `AssemblyInfo.cs` with: ```csharp [assembly: UsesPermission(Android.Manifest.Permission.ReadExternalStorage)] ``` Fixes: #2678
jsuarezruiz
added
area-blazor
pranavkm
reviewed
Feb 25, 2022
TanayParikh
commented
Feb 25, 2022
| return base.OnShowFileChooser(view, filePathCallback, fileChooserParams); | ||
| } | ||
|
|
||
| CallFilePickerAsync(filePathCallback, fileChooserParams).FireAndForget(); |
There was a problem hiding this comment.
Actual logging (via FireAndForget's error callback) will be handled via #4441.
| @@ -15,7 +15,8 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <Compile Include="..\SharedSource\**\*.cs" Link="Windows\SharedSource\%(Filename)%(Extension)"/> | |||
| <Compile Include="..\SharedSource\**\*.cs" Link="Windows\SharedSource\%(Filename)%(Extension)" /> | |||
| <Compile Include="..\..\..\Core\src\TaskExtensions.cs" Link="Utilities\TaskExtensions.cs" /> | |||
There was a problem hiding this comment.
I should just be able to use the TaskExtensions however they aren't being supported in the net6.0-android context. Added a file reference instead.
pranavkm
approved these changes
Feb 26, 2022
|
One thing to be aware of is if you target Android 30+ which is basically required READ_EXTERNAL_STORAGE is super not really allowed anymore :( |
|
I think this PR can stay merged, but I re-opened the bug so we can follow up on this issue. |
|
Thanks! Android 30+ compatibility issues should automatically be resolved when xamarin/Essentials#1961 is fixed. Left a comment in #2678 (comment). |
samhouts
added
the
fixed-in-6.0.200-preview.14.2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables selecting files within the Blazor WebView (includes both
<InputFile />and<input type="file">).The Blazor Android WebView was updated to utilize the MAUI Essentials File Picker API. Thanks @mattleibow for the tip!
Note, you'll need to add the
READ_EXTERNAL_STORAGEpermission to yourAndroidManifest.xml:or update the
AssemblyInfo.cswith:Fixes: #2678