Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS/MacCatalyst] Fix SearchBar TextChanged event not working issue #5462

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Mar 21, 2022

Description of Change

Fix SearchBar TextChanged event not working issue on iOS/MacCatalyst.

To test it, launch the .NET MAUI Gallery and navigate to Controls > SearchBar. Write something in the latest SearchBar and see in the Output the result.

Issues Fixed

Fixes #5326

@Redth Redth added this to the 6.0.300-rc.2 milestone Mar 21, 2022
if (_editor != null)
_editor.EditingChanged += OnEditingChanged;

SetupDefaults(platformView);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the SetupDefaults from this? if you merge with main that might delete it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PureWeen Updated, could you review it again?. Thanks!.

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 23, 2022
@rmarinho rmarinho merged commit 43547cb into main Mar 30, 2022
@rmarinho rmarinho deleted the fix-5326 branch March 30, 2022 17:00
@mattleibow mattleibow modified the milestones: 6.0.300-rc.2, 6.0.300-rc.1 Mar 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-entry Entry fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchBar Text changed Event is not triggered in iOS and MacCatalyst Platform
7 participants