[android] update AOT profiles #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lots of APIs changed, and we noticed our lab's perf dashboard shows
the .NET Podcast app going from 1036ms to 1068ms on a Pixel 4a device.
Updating the profile, I get better numbers on a Pixel 5:
Before:
Average(ms): 858.1
After:
Average(ms): 835.7
This was a 10-run average of the .NET Podcast app.
Redth
approved these changes
Mar 30, 2022
eerhardt
reviewed
Mar 30, 2022
| @@ -1082,15 +1080,10 @@ Methods: | |||
| int System.Private.CoreLib.Interop/Sys:PRead (System.Runtime.InteropServices.SafeHandle,byte*,int,long) | |||
| int System.Random:Next (int,int) | |||
| int System.Random/XoshiroImpl:Next (int,int) | |||
| int System.Reflection.Emit.DynamicMethod:AddRef (object) | |||
eerhardt
reviewed
Mar 30, 2022
| @@ -553,9 +554,6 @@ Methods: | |||
| bool System.Net.Http.HttpRuleParser:IsTokenChar (char) | |||
| bool System.Net.Http.QPack.QPackEncoder:EncodeNameString (string,System.Span`1<byte>,int&) | |||
| bool System.Number:TryFormatInt32 (int,int,System.ReadOnlySpan`1<char>,System.IFormatProvider,System.Span`1<char>,int&) | |||
| bool System.Number:TryParseDouble (System.ReadOnlySpan`1<char>,System.Globalization.NumberStyles,System.Globalization.NumberFormatInfo,double&) | |||
There was a problem hiding this comment.
Kind of interesting that something this low-level is no longer needed. Parsing numbers is pretty basic.
There was a problem hiding this comment.
I think a fair bit has moved into the xaml compiler. @StephaneDelcroix has been doing some magic there.
There was a problem hiding this comment.
@eerhardt I'll double check some of these, probably worth looking at methods.txt in the .NET Podcast app and see what the slowest JIT-d methods are.
eerhardt
approved these changes
Mar 30, 2022
mattleibow
approved these changes
Mar 30, 2022
Eilon
added
the
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of APIs changed, and we noticed our lab's perf dashboard shows
the .NET Podcast app going from 1036ms to 1068ms on a Pixel 4a device.
Updating the profile, I get better numbers on a Pixel 5:
This was a 10-run average of the .NET Podcast app.