Spike adding implictor styles to handle null colors #6255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
approved these changes
Apr 20, 2022
PureWeen
force-pushed
the
implicitor_styles
branch
2 times, most recently
from
1234027
to
1eae6c1
Compare
PureWeen
commented
Apr 21, 2022
| Color ITextStyle.TextColor | ||
| { | ||
| get => TextColor ?? | ||
| DefaultStyles.GetTextColor(this)?.Value as Color; |
There was a problem hiding this comment.
If the value in Controls gets forcefully set to null then we just revert back to the implicit style here
PureWeen
force-pushed
the
implicitor_styles
branch
from
845b5f2
to
9cd25bd
Compare
PureWeen
force-pushed
the
implicitor_styles
branch
from
87480fa
to
a23a807
Compare
Eilon
added
the
legacy-area-controls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Because of the inability to define default styles in xaml this PR attempts to just codify a set of defaults that will act the same as an included XAML file.
The end goal will be to have something like this implicitly included into your MAUI project.
Then if users want to change theme colors they only have to modify a small set of colors to affect the entire application.