Set GenerateDocumentationFile=true for MAUI Essentials #6907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
commented
May 6, 2022
| @@ -8,6 +8,8 @@ | |||
| <NoWarn>$(NoWarn);CA1416</NoWarn> | |||
| <IsPackable>false</IsPackable> | |||
| <IsTrimmable>true</IsTrimmable> | |||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | |||
| <NoWarn>$(NoWarn);CS1591</NoWarn> | |||
There was a problem hiding this comment.
Same as before: Need to ignore missing doc comments (for now, anyway).
Eilon
commented
May 6, 2022
| @@ -180,7 +180,7 @@ public ShareMultipleFilesRequest() | |||
| { | |||
| } | |||
|
|
|||
| /// <include file="../../docs/Microsoft.Maui.Essentials/ShareMultipleFilesRequest.xml" path="//Member[@MemberName='.ctor'][1]/Docs" /> | |||
| /// <include file="../../docs/Microsoft.Maui.Essentials/ShareMultipleFilesRequest.xml" path="//Member[@MemberName='.ctor'][3]/Docs" /> | |||
There was a problem hiding this comment.
The various scripts we previously used to import existing docs often got things mixed up with overloads. This fixes such mix-ups by selecting the correct overload.
mattleibow
approved these changes
May 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Similar to #6874, this enables XML doc comments for MAUI Essentials, which also has a ton of XML docs, but they're not published.
Issues Fixed
Partial fix for #5341