Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set GenerateDocumentationFile=true for Compatibility and Xaml and pack a special docs artifact #7511

Merged
merged 3 commits into from
May 27, 2022

Conversation

mattleibow
Copy link
Member

Description of Change

This is to be used by something. Will probably be auto-pushed somewhere in a release step.

@mattleibow mattleibow requested a review from Redth May 26, 2022 21:16
@Eilon Eilon added the area-docs Conceptual docs, API docs, Samples label May 26, 2022
@Eilon
Copy link
Member

Eilon commented May 26, 2022

This looks like it's similar to some of the API docs stuff I've done for other assemblies, but with additional CAKE changes. What are those for?

My past changes:

@mattleibow
Copy link
Member Author

The cake changes are to just merge all the dll/xml files into a single artifact to upload to some binary drop for the docs people I think. @Redth has more info.

@mattleibow mattleibow changed the title Pack a special docs artifact Set GenerateDocumentationFile=true for Compatibility and Xaml and pack a special docs artifact May 26, 2022
@mattleibow mattleibow marked this pull request as ready for review May 27, 2022 02:00
@mattleibow mattleibow merged commit 304850a into main May 27, 2022
@mattleibow mattleibow deleted the dev/docs-packs branch May 27, 2022 02:00
@Eilon
Copy link
Member

Eilon commented May 27, 2022

The cake changes are to just merge all the dll/xml files into a single artifact to upload to some binary drop for the docs people I think. @Redth has more info.

Ah OK so we wouldn't push that to NuGet.org or anything, or bundle it in the workload/installer?

@mattleibow
Copy link
Member Author

Correct. It is in a separate artifact entirely, so if anyone is pulling that, then that is incorrect. Also, it is not in a nuget package - just a folder. So it will be even harder to accidentally do things with.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-docs Conceptual docs, API docs, Samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants