Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Transformations #717

Merged
merged 26 commits into from
May 31, 2021
Merged

View Transformations #717

merged 26 commits into from
May 31, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Include View Transformation support in .NET MAUI. Include:

double TranslationX { get; }
double TranslationY { get; }
double Scale { get; }
double ScaleX { get; }
double ScaleY { get; }
double Rotation { get; }
double RotationX { get; }
double RotationY { get; }
double AnchorX { get; }
double AnchorY { get; }

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

No

@PureWeen PureWeen changed the base branch from main to release/6.0.1xx-preview4 April 29, 2021 00:33
src/Core/src/Core/IFrameworkElement.cs Show resolved Hide resolved
src/Core/src/Handlers/View/ViewHandler.Windows.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/View/ViewHandler.iOS.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/View/ViewHandler.iOS.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/View/ViewHandler.iOS.cs Outdated Show resolved Hide resolved
src/Core/src/Platform/iOS/TransformationExtensions.cs Outdated Show resolved Hide resolved
src/Core/src/Platform/iOS/TransformationExtensions.cs Outdated Show resolved Hide resolved
src/Core/src/Platform/iOS/TransformationExtensions.cs Outdated Show resolved Hide resolved
@mattleibow mattleibow changed the base branch from release/6.0.1xx-preview4 to main May 25, 2021 20:22
# Conflicts:
#	src/Core/src/Handlers/View/ViewHandler.cs
#	src/Core/tests/DeviceTests/Handlers/HandlerTestBase.Android.cs
#	src/Core/tests/DeviceTests/Handlers/HandlerTestBase.iOS.cs
#	src/Core/tests/UnitTests/TestClasses/ViewStub.cs
@mattleibow
Copy link
Member

mattleibow commented May 26, 2021

I think this is ready, except for some reason iOS is also resizing the views as they transform.

@jsuarezruiz
Copy link
Contributor Author

This PR also enable the animations using Microsoft.Maui.Controls.Animation:
maui-animations

Should we have Animations in Core or Controls?

@hartez
Copy link
Contributor

hartez commented May 28, 2021

I think this is ready, except for some reason iOS is also resizing the views as they transform.

This should be fixed by commit 8a85633

2021-05-28_16-45-12 (1)

@saint4eva
Copy link

This PR also enable the animations using Microsoft.Maui.Controls.Animation:
maui-animations

Should we have Animations in Core or Controls?

The Animations should be in Core so other app model such as Comet and Fabulous can make use of them. Putting them in controls means only xaml can use them properly. Please consider other app models while designing and developing the apis.

@mattleibow
Copy link
Member

mattleibow commented May 31, 2021

Should we have Animations in Core or Controls?

@jsuarezruiz I believe @Clancey was looking at the ticker/timer and animations.

Please consider other app models while designing and developing the apis

@saint4eva no need to worry! @Clancey is on that!

@Clancey
Copy link
Contributor

Clancey commented May 31, 2021

Yes for now animations are fine the way they are. We will get them in core! But that’s a different pull request.

@mattleibow mattleibow merged commit 7de6dca into main May 31, 2021
@mattleibow mattleibow deleted the transformations branch May 31, 2021 15:47
@saint4eva
Copy link

Should we have Animations in Core or Controls?

@jsuarezruiz I believe @Clancey was looking at the ticker/timer and animations.

Please consider other app models while designing and developing the apis

@saint4eva no need to worry! @Clancey is on that!

👍

lytico pushed a commit to lytico/maui that referenced this pull request Jun 8, 2021
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.100-preview.5 Look for this fix in 6.0.100-preview.5! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants