Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the image handler to measure more accurately WRT aspect ratio #7389

Merged
merged 1 commit into from May 23, 2022

Conversation

hartez
Copy link
Contributor

@hartez hartez commented May 21, 2022

Description of Change

Allows the Android ImageView measure call to account for the intrinsic aspect ratio of the image when measuring with constraints. Otherwise, the image measurement will always come back with the intrinsic size of the image, which is almost never what we want when downscaling an image to fit a space.

Issues Fixed

Fixes #2000 for Android; does not address iOS.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented May 23, 2022

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 23, 2022

Azure Pipelines successfully started running 2 pipeline(s).

@hartez hartez merged commit cf3b399 into main May 23, 2022
24 checks passed
@hartez hartez deleted the fix-2000 branch May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants