Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix issue using DynamicResource TextColor on Label FormattedString #7793

Merged
merged 5 commits into from
Jun 23, 2022
Merged

[Android] Fix issue using DynamicResource TextColor on Label FormattedString #7793

merged 5 commits into from
Jun 23, 2022

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix issue using DynamicResource TextColor on Label FormattedString on Android.

Issues Fixed

Fixes #7464

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android 🤖 area-controls-label Label, Span labels Jun 6, 2022
@jsuarezruiz jsuarezruiz added this to the 6.0-sr1 milestone Jun 6, 2022
@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jun 6, 2022
@rmarinho
Copy link
Member

rmarinho commented Jun 6, 2022

You need to update the Unshipped api, you can use the IDE to do that

@hartez hartez modified the milestones: 6.0-sr1, 6.0-sr2 Jun 6, 2022
@hartez
Copy link
Contributor

hartez commented Jun 14, 2022

@jsuarezruiz Needs to be targeted to net6.0 branch.

@mattleibow mattleibow changed the base branch from main to net6.0 June 18, 2022 05:27
@mattleibow mattleibow requested a review from a team as a code owner June 18, 2022 05:27
mattleibow
mattleibow requested changes Jun 18, 2022
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a DeviceTest for this? I am assuming this is not directly related to dynamic resources but rather the fact that the text color is changing after the UI is rendered?

@jsuarezruiz
Copy link
Contributor Author

Can we add a DeviceTest for this? I am assuming this is not directly related to dynamic resources but rather the fact that the text color is changing after the UI is rendered?

Is not related with dynamic resources, is about invalidate the spans color. Added a device test to validate it.

@hartez hartez merged commit aa9691b into net6.0 Jun 23, 2022
@hartez hartez deleted the fix-7464 branch June 23, 2022 15:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.408 Look for this fix in 6.0.408! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@mattleibow mattleibow Awaiting requested review from mattleibow

@rmarinho rmarinho Awaiting requested review from rmarinho

Assignees
No one assigned
Labels
area-controls-label Label, Span fixed-in-6.0.408 Look for this fix in 6.0.408! platform/android 🤖 t/bug Something isn't working
Projects
None yet
Milestone
6.0-sr2
Development

Successfully merging this pull request may close these issues.

DynamicResource TextColor doesn't work on labels with formatted string
6 participants
@jsuarezruiz @rmarinho @hartez @mattleibow @Eilon @samhouts