Skip to content

Commit

Permalink
Merge pull request #7663 from rainersigwald/backport-keypair-elision-…
Browse files Browse the repository at this point in the history
…16.11

Fixes dotnet/sdk#25698 for 16.11, merging forward (+ infrastructure updates).
  • Loading branch information
rainersigwald committed Jun 1, 2022
2 parents 14052b1 + 420c4f7 commit 5d7fe36
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .vsts-dotnet-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ jobs:
condition: eq(1,2)
displayName: "macOS Mono"
pool:
vmImage: 'macOS-10.14'
vmImage: 'macOS-latest'
steps:
# https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops&tabs=yaml#mono
- bash: |
Expand Down
4 changes: 2 additions & 2 deletions .vsts-dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,14 +74,14 @@ stages:
signType: $(SignType)
zipSources: false
condition: and(succeeded(), in(variables['SignType'], 'test', 'real'))

- task: MicroBuildOptProfPlugin@6
inputs:
ProfilingInputsDropName: '$(VisualStudio.DropName)'
ShouldSkipOptimize: true
AccessToken: '$(System.AccessToken)'
feedSource: 'https://devdiv.pkgs.visualstudio.com/DefaultCollection/_packaging/MicroBuildToolset/nuget/v3/index.json'
displayName: 'Install OptProf Plugin'
displayName: 'Install OptProf Plugin'

# Required by MicroBuildBuildVSBootstrapper
- task: ms-vseng.MicroBuildTasks.32f78468-e895-4f47-962c-58a699361df8.MicroBuildSwixPlugin@1
Expand Down
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<Dependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.22123.4">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="5.0.0-beta.22276.2">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>295d305a5520815cbf4ccb3f209f6ee8ba11b45d</Sha>
<Sha>9c6a04ea1e79e9fcd4e60abd5d2c577075787f93</Sha>
</Dependency>
<Dependency Name="NuGet.Build.Tasks" Version="5.9.1-rc.8">
<Uri>https://github.com/nuget/nuget.client</Uri>
Expand Down
7 changes: 3 additions & 4 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
<!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the MIT license. See License.txt in the project root for full license information. -->
<Project>
<PropertyGroup>
<VersionPrefix>16.11.2</VersionPrefix>
<DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<VersionPrefix>16.11.3</VersionPrefix><DotNetFinalVersionKind>release</DotNetFinalVersionKind>
<AssemblyVersion>15.1.0.0</AssemblyVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<DotNetUseShippingVersions>true</DotNetUseShippingVersions>
Expand All @@ -28,9 +27,9 @@
<PropertyGroup>
<!-- DotNetCliVersion MUST match the dotnet version in global.json.
Otherwise, this version of dotnet will not be installed and the build will error out. -->
<DotNetCliVersion>5.0.401</DotNetCliVersion>
<DotNetCliVersion>5.0.408</DotNetCliVersion>
<MicrosoftNetCompilersToolsetVersion>3.9.0-2.20574.26</MicrosoftNetCompilersToolsetVersion>
<NuGetBuildTasksVersion>5.11.0-rc.10</NuGetBuildTasksVersion>
<NuGetBuildTasksVersion>5.11.1-rc.5</NuGetBuildTasksVersion>
</PropertyGroup>
<Target Name="OverrideArcadeFileVersion" AfterTargets="_InitializeAssemblyVersion">
<!-- See https://github.com/dotnet/arcade/issues/3386
Expand Down
1 change: 1 addition & 0 deletions eng/common/templates/post-build/post-build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"tools": {
"dotnet": "5.0.401",
"dotnet": "5.0.408",
"runtimes": {
"dotnet/x64": [
"2.1.7"
Expand All @@ -12,6 +12,6 @@
},
"msbuild-sdks": {
"Microsoft.Build.CentralPackageVersions": "2.0.1",
"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.22123.4"
"Microsoft.DotNet.Arcade.Sdk": "5.0.0-beta.22276.2"
}
}
6 changes: 6 additions & 0 deletions src/Shared/AssemblyNameExtension.cs
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,9 @@ private AssemblyNameExtension(SerializationInfo info, StreamingContext context)
var hashAlgorithm = (System.Configuration.Assemblies.AssemblyHashAlgorithm) info.GetInt32("hashAlg");
var versionCompatibility = (AssemblyVersionCompatibility) info.GetInt32("verCompat");
var codeBase = info.GetString("codebase");
#if NETFRAMEWORK
var keyPair = (StrongNameKeyPair) info.GetValue("keypair", typeof(StrongNameKeyPair));
#endif

asAssemblyName = new AssemblyName
{
Expand All @@ -160,7 +162,9 @@ private AssemblyNameExtension(SerializationInfo info, StreamingContext context)
HashAlgorithm = hashAlgorithm,
VersionCompatibility = versionCompatibility,
CodeBase = codeBase,
#if NETFRAMEWORK
KeyPair = keyPair
#endif
};

asAssemblyName.SetPublicKey(publicKey);
Expand Down Expand Up @@ -1001,7 +1005,9 @@ public void GetObjectData(SerializationInfo info, StreamingContext context)
info.AddValue("hashAlg", asAssemblyName.HashAlgorithm);
info.AddValue("verCompat", asAssemblyName.VersionCompatibility);
info.AddValue("codebase", asAssemblyName.CodeBase);
#if NETFRAMEWORK
info.AddValue("keypair", asAssemblyName.KeyPair);
#endif
}

info.AddValue("asStr", asString);
Expand Down

0 comments on commit 5d7fe36

Please sign in to comment.