Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport keypair elision 16.11 #7663

Merged

Conversation

rainersigwald
Copy link
Member

Fixes #

Work item (Internal use):

Summary

Customer Impact

Regression?

Testing

Risk

dotnet-maestro bot and others added 6 commits March 10, 2022 13:24
…309.5

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.22123.4 -> To Version 5.0.0-beta.22159.5
…526.2

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.22123.4 -> To Version 5.0.0-beta.22276.2
* Avoid AssemblyName.KeyPair on .NET

It throws on .NET 6 and wasn't helpful before anyway:

(from https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assemblyname.keypair?view=net-5.0#remarks):

> When the runtime loads an assembly, it does not set the KeyPair property. The getter for the property is only useful if the user set the property before using the AssemblyName object to create a dynamic assembly, and subsequently wants to retrieve the key pair.

Also disable some parts of the official build that are currently broken, but don't affect building the bits that go into the .NET SDK.

Co-authored-by: Forgind <Forgind@users.noreply.github.com>
@rainersigwald rainersigwald marked this pull request as ready for review June 1, 2022 18:58
@rainersigwald rainersigwald merged commit 5d7fe36 into dotnet:vs16.11 Jun 1, 2022
@rainersigwald rainersigwald deleted the backport-keypair-elision-16.11 branch June 1, 2022 19:02
AR-May added a commit that referenced this pull request Dec 21, 2022
…to-vs17.0-2

Backport opt-prof v2 vs17.0 

- [vs16.11] Update dependencies from dotnet/arcade (#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request #8210 from rainersigwald/exp/16.11-build

### Testing
CI, Opt-prof CI
AR-May added a commit that referenced this pull request Jan 10, 2023
…o-vs17.2

Backport opt-prof v2 vs17.2

Brings the following changes from the 17.0 branch into 17.2:
- [vs16.11] Update dependencies from dotnet/arcade (#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request #8210 from rainersigwald/exp/16.11-build
- Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge pull request #8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2

### Testing
CI
AR-May added a commit that referenced this pull request Jan 19, 2023
…o-vs17.4

Backport opt-prof v2 vs17.4

Brings the following changes from the 17.2 branch into 17.4:
- [vs16.11] Update dependencies from dotnet/arcade (#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request #8210 from rainersigwald/exp/16.11-build
- Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge pull request #8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge remote-tracking branch 'upstream/vs17.0' into exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2
- Merge pull request #8264 from AR-May/exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2

### Testing
CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants