FileTracker should be consumed from a package #649
Labels
Comments
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this issue
May 24, 2016
This works around the lack of dotnet#649 combined with the `FileTracker{32,64}.dll` rename. The C# side of the rename-handling is being pushed to GitHub, but these tests will fail until the renamed native files are available on a given machine.
|
This doesn't seem that important at the moment. |
This was referenced Jan 25, 2023
Forgind
added a commit
that referenced
this issue
Jan 26, 2023
(Copied from #8351) Fixes AB#1678521 Context #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects. Changes Made Reverted the change. Enabled relevant unit tests. Testing Existing unit tests and a C++ end-to-end repro. Notes The rest of FileTracker tests cannot be enabled without significant work (related to #649).
Forgind
added a commit
that referenced
this issue
Feb 7, 2023
(Copied from #8351) Fixes AB#1678521 Context #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects. Changes Made Reverted the change. Enabled relevant unit tests. Testing Existing unit tests and a C++ end-to-end repro. Notes The rest of FileTracker tests cannot be enabled without significant work (related to #649).
Forgind
added a commit
that referenced
this issue
Feb 13, 2023
Fixes AB#1678521 Context #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects. Changes Made Reverted the change. Enabled relevant unit tests. Testing Existing unit tests and a C++ end-to-end repro. Notes The rest of FileTracker tests cannot be enabled without significant work (related to #649).
JaynieBai
pushed a commit
that referenced
this issue
Feb 14, 2023
Fixes AB#1678521 Context #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects. Changes Made Reverted the change. Enabled relevant unit tests. Testing Existing unit tests and a C++ end-to-end repro. Notes The rest of FileTracker tests cannot be enabled without significant work (related to #649).
JanKrivanek
added a commit
that referenced
this issue
Apr 26, 2023
commit 81da5a2 Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Wed Apr 26 10:17:54 2023 -0700 [vs17.2] Temporary turn off static graph restore. (#8697) Turn off static graph restore. (Backport of #8498 to vs17.2) commit 872ddd9 Merge: 94fcedf 6faa1d5 Author: Forgind <12969783+Forgind@users.noreply.github.com> Date: Mon Feb 13 07:30:47 2023 -0800 Merge pull request #8419 from Forgind/fix-temp-file-filtering-17.2 Fixes AB#1678521 Context #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects. Changes Made Reverted the change. Enabled relevant unit tests. Testing Existing unit tests and a C++ end-to-end repro. Notes The rest of FileTracker tests cannot be enabled without significant work (related to #649). commit 6faa1d5 Merge: 94fcedf 2fdde65 Author: Forgind <Forgind@users.noreply.github.com> Date: Tue Feb 7 14:56:15 2023 -0800 Merge branch 'vs17.0' of https://github.com/dotnet/msbuild into vs17.2 commit 2fdde65 Author: Forgind <12969783+Forgind@users.noreply.github.com> Date: Tue Feb 7 09:06:10 2023 -0800 Fix temp file filtering in FileTracker (#8352) (Copied from #8351) Fixes AB#1678521 Context #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects. Changes Made Reverted the change. Enabled relevant unit tests. Testing Existing unit tests and a C++ end-to-end repro. Notes The rest of FileTracker tests cannot be enabled without significant work (related to #649).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The source code for
Tracker.exeandFileTracker.dllis not open source, but those assemblies are part of the MSBuild binary distribution. We should build them internally and make them available as a package so that the built-from-GitHub version of MSBuild can include them and ship them back into Visual Studio (or other consumers). Currently tests fall back to the installed versions, which makes testing coordinated changes very difficult.The text was updated successfully, but these errors were encountered: