Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix temp file filtering 17.2 #8419

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Fix temp file filtering 17.2 #8419

merged 2 commits into from
Feb 13, 2023

Conversation

Forgind
Copy link
Member

@Forgind Forgind commented Feb 7, 2023

See #8351

Forgind and others added 2 commits February 7, 2023 09:06
@Forgind
Fix temp file filtering in FileTracker (dotnet#8352)
2fdde65 
(Copied from dotnet#8351)

Fixes AB#1678521

Context
dotnet#8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

Changes Made
Reverted the change. Enabled relevant unit tests.

Testing
Existing unit tests and a C++ end-to-end repro.

Notes
The rest of FileTracker tests cannot be enabled without significant work (related to dotnet#649).
@Forgind
Merge branch 'vs17.0' of https://github.com/dotnet/msbuild into vs17.2
6faa1d5
@Forgind Forgind marked this pull request as ready for review February 7, 2023 22:57
@Forgind Forgind merged commit 872ddd9 into dotnet:vs17.2 Feb 13, 2023
@Forgind Forgind deleted the fix-temp-file-filtering-17.2 branch February 13, 2023 15:30
JanKrivanek added a commit that referenced this pull request Apr 26, 2023
@JanKrivanek
Squashed commit of the following:
088081e 
commit 81da5a2
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Wed Apr 26 10:17:54 2023 -0700

    [vs17.2] Temporary turn off static graph restore. (#8697)

    Turn off static graph restore.

    (Backport of #8498 to vs17.2)

commit 872ddd9
Merge: 94fcedf 6faa1d5
Author: Forgind <12969783+Forgind@users.noreply.github.com>
Date:   Mon Feb 13 07:30:47 2023 -0800

    Merge pull request #8419 from Forgind/fix-temp-file-filtering-17.2

    Fixes AB#1678521

    Context
    #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

    Changes Made
    Reverted the change. Enabled relevant unit tests.

    Testing
    Existing unit tests and a C++ end-to-end repro.

    Notes
    The rest of FileTracker tests cannot be enabled without significant work (related to #649).

commit 6faa1d5
Merge: 94fcedf 2fdde65
Author: Forgind <Forgind@users.noreply.github.com>
Date:   Tue Feb 7 14:56:15 2023 -0800

    Merge branch 'vs17.0' of https://github.com/dotnet/msbuild into vs17.2

commit 2fdde65
Author: Forgind <12969783+Forgind@users.noreply.github.com>
Date:   Tue Feb 7 09:06:10 2023 -0800

    Fix temp file filtering in FileTracker (#8352)

    (Copied from #8351)

    Fixes AB#1678521

    Context
    #8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

    Changes Made
    Reverted the change. Enabled relevant unit tests.

    Testing
    Existing unit tests and a C++ end-to-end repro.

    Notes
    The rest of FileTracker tests cannot be enabled without significant work (related to #649).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladipro ladipro ladipro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Forgind @ladipro