Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky test] - ToolTaskThatTimeoutAndRetry is randomly failing #8750

Closed
JanKrivanek opened this issue May 11, 2023 · 1 comment · Fixed by #8800
Closed

[Flaky test] - ToolTaskThatTimeoutAndRetry is randomly failing #8750

JanKrivanek opened this issue May 11, 2023 · 1 comment · Fixed by #8800
Assignees
@JaynieBai
Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. bug triaged

Comments

@JanKrivanek
Copy link
Member

JanKrivanek commented May 11, 2023 •
edited

Issue Description

Context

The ToolTaskThatTimeoutAndRetry test needs an external process to wait for the timeout. PowerShell sleep is used for windows - that however prooves to be a bit unstable in CI

Evidence

#8659
#8749 (comment)

Suggestions

  • Use other host then PowerShell.exe (e.g. cmd.exe)
  • Overload the ExecuteTool method of the ToolTask - so that no external process actually needs to be executed
  • Write one-off sleep .exe (overkill)
  • ?
@JanKrivanek JanKrivanek added bug Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. needs-triage Have yet to determine what bucket this goes in. labels May 11, 2023
@AR-May
Copy link
Member

AR-May commented May 16, 2023

Somewhere in the tests there should be the sleep task or target which does not have the problem, so we would want to use it here instead of PowerShell sleep.

@AR-May AR-May removed the needs-triage Have yet to determine what bucket this goes in. label May 16, 2023
@rainersigwald rainersigwald mentioned this issue May 22, 2023
Merged
@JaynieBai JaynieBai mentioned this issue May 29, 2023
Merged
JaynieBai added a commit that referenced this issue May 31, 2023
@JaynieBai
Enable ToolTaskThatTimeoutAndRetry test after change powershell.exe t…
2b198f8 
…o cmd.exe (#8800)

Fixes #8750

Context
PowerShell sleep is used for windows - that however prooves to be a bit unstable in CI

Changes Made
Use cmd.exe

Testing
/azp run for several times. It passed.
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaynieBai JaynieBai

Labels
Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. bug triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable ToolTaskThatTimeoutAndRetry test after change powershell.exe to cmd.exe dotnet/msbuild
3 participants
@JanKrivanek @JaynieBai @AR-May