Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ToolTaskThatTimeoutAndRetry test after change powershell.exe to cmd.exe #8800

Merged
merged 6 commits into from May 31, 2023

Conversation

JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented May 26, 2023

Fixes #8750

Context

PowerShell sleep is used for windows - that however prooves to be a bit unstable in CI

Changes Made

Use cmd.exe

Testing

/azp run for several times. It passed.

Notes

@JaynieBai
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JaynieBai
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JaynieBai JaynieBai marked this pull request as ready for review May 29, 2023 08:19
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JaynieBai
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JaynieBai JaynieBai changed the title Enable ToolTaskThatTimeoutAndRetry test for varification Enable ToolTaskThatTimeoutAndRetry test after change powershell.exe to cmd.exe May 29, 2023
@JaynieBai JaynieBai requested a review from Forgind May 30, 2023 01:48
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

src/Utilities.UnitTests/ToolTask_Tests.cs Outdated Show resolved Hide resolved
@JaynieBai
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JaynieBai JaynieBai merged commit 2b198f8 into main May 31, 2023
8 checks passed
@JaynieBai JaynieBai deleted the jennybai/issue8750 branch May 31, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky test] - ToolTaskThatTimeoutAndRetry is randomly failing
3 participants