Exec task unicode fix #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On an OS >= Windows 7 (v6.1), the Exec command will now using UTF-8 (w/o BOM) encoding for Console output and writing the temporary .cmd file. This will enable non-ansi characters in the Command property to work as expected. - Added a unit test to cover the scenario.
|
LGTM. |
| if (EncodingUtilities.CurrentSystemOemEncoding.CodePage != sw.Encoding.CodePage) | ||
| { | ||
| // Output to nul so we don't change output and logs. | ||
| sw.WriteLine($"chcp {sw.Encoding.CodePage}>nul"); |
There was a problem hiding this comment.
You're using C#6 features here, is the solution already updated to that?
There was a problem hiding this comment.
Good point, probably best to just not go there at this point. Especially for a single change and I'm not sure what it would do to the xplat / Xamarin Studio story when this gets merged.
|
Left some comments, LGTM otherwise (though I'd preferred if the reformatting of the properties etc. were done in a separate commit, so the real change is easier to see). |
radical
added a commit
to radical/msbuild
that referenced
this pull request
Oct 7, 2019
[2019-08] Update SDKs to track vs16.4 and `.NET Core 3.1 Dev`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142 and probably #104 (thanks @akoeplinger for pointing that out!).
Definitely not an expect on code pages and cmd.exe encoding, but this works better than previously in all the scenarios I tested.
The only remaining encoding issue I found is if the command you run has non-ansi characters (e.g.
echo 创建was the test case I used), it will still show up as ?? on the console. I don't think that can be fixed here though.