Merge Unicode-related exec changes into xplat #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On an OS >= Windows 7 (v6.1), the Exec command will now using UTF-8 (w/o BOM) encoding for Console output and writing the temporary .cmd file. This will enable non-ansi characters in the Command property to work as expected. - Added a unit test to cover the scenario.
Exec task unicode fix
Conflicts: src/XMakeTasks/Exec.cs src/XMakeTasks/UnitTests/Exec_Tests.cs
|
@AndyGerlicher, @ValMenn - can y'all sanity-check this? |
|
LGTM. Looks more painful than it should have been, sorry! |
rainersigwald
added a commit
that referenced
this pull request
Aug 24, 2015
Merge Unicode-related exec changes into xplat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just catches us up to the latest master, but it's a nontrivial merge so I figured I'd get it reviewed separately.