Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feedSource parameter from MicroBuild task #5895

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

benvillalobos
Copy link
Member

In a conversation between Rainer and Rick Krause

Rick mentions:

You’re using the wrong package feed— https://devdiv-test.pkgs.visualstudio.com/DefaultCollection/_packaging/MicroBuildToolset/nuget/v3/index.json.
Change the feed source in your task to https://devdiv.pkgs.visualstudio.com/DefaultCollection/_packaging/MicroBuildToolset/nuget/v3/index.json

And:

Actually, you could drop the feedSource value altogether, since it defaults to the value I said to use.
Thanks, Rick

It gets passed the step, but fails now at signing validation
image

[error].packages\microsoft.dotnet.arcade.sdk\1.0.0-beta.20509.7\tools\SdkTasks\SigningValidation.proj(56,5): error : Signing validation failed. Check signcheck.errors.log for more information.

Pipeline Build: https://dev.azure.com/devdiv/DevDiv/_build/results?buildId=4237997&view=results

@Forgind
Copy link
Member

Forgind commented Nov 19, 2020

Signing problem was https://github.com/dotnet/core-eng/issues/11458, right?

@benvillalobos
Copy link
Member Author

benvillalobos commented Nov 20, 2020

I believe per https://github.com/dotnet/core-eng/issues/11458#issuecomment-730710439 we'd need to add
1.0.0-beta.20569.8
to our eng/versions.props file. This would unblock us on the MicroBuild feedSource issue and the arcade signing issue. PR's would likely have to rebase off of master to pull in the workaround.

This PR + #5893 should fix our pipelines

@rainersigwald rainersigwald merged commit 1295210 into master Nov 20, 2020
@rainersigwald rainersigwald deleted the vsts-remove-feedsource branch November 20, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants