Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FindOnPathSucceeds failing on some Linux flavors #6055

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

tmds
Copy link
Member

@tmds tmds commented Jan 21, 2021

Fixes #4781, #3580.

@Forgind ptal.

Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can't check against cmdPath, though 🙂

src/Utilities.UnitTests/ToolTask_Tests.cs Outdated Show resolved Hide resolved
src/Utilities.UnitTests/ToolTask_Tests.cs Outdated Show resolved Hide resolved
Copy link
Member

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 22, 2021
@Forgind Forgind merged commit e8016bb into dotnet:master Feb 4, 2021
@Forgind
Copy link
Member

Forgind commented Feb 4, 2021

Thanks @tmds!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msbuild -test returns a false positive on Manjaro Linux
3 participants