Avoid AssemblyName.KeyPair on .NET #7660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It throws on .NET 6 and wasn't helpful before anyway: (from https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assemblyname.keypair?view=net-5.0#remarks): > When the runtime loads an assembly, it does not set the KeyPair property. The getter for the property is only useful if the user set the property before using the AssemblyName object to create a dynamic assembly, and subsequently wants to retrieve the key pair.
Maybe just kill mono?
Forgind
approved these changes
Jun 1, 2022
AR-May
added a commit
that referenced
this pull request
Dec 21, 2022
…to-vs17.0-2 Backport opt-prof v2 vs17.0 - [vs16.11] Update dependencies from dotnet/arcade (#7332) - Update dependencies from https://github.com/dotnet/arcade build 20220309.5 - Update dependencies from https://github.com/dotnet/arcade build 20220526.2 - Bump CLI version to match global.json - Bump NuGet version to match - Avoid AssemblyName.KeyPair on .NET (#7660) - Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11 - Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11 - Configure OptProf v2 pipeline 16.11 (#8189) - Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12' - Move BAR publish to windows-latest - Merge pull request #8210 from rainersigwald/exp/16.11-build ### Testing CI, Opt-prof CI
AR-May
added a commit
that referenced
this pull request
Jan 10, 2023
…o-vs17.2 Backport opt-prof v2 vs17.2 Brings the following changes from the 17.0 branch into 17.2: - [vs16.11] Update dependencies from dotnet/arcade (#7332) - Update dependencies from https://github.com/dotnet/arcade build 20220309.5 - Update dependencies from https://github.com/dotnet/arcade build 20220526.2 - Bump CLI version to match global.json - Bump NuGet version to match - Avoid AssemblyName.KeyPair on .NET (#7660) - Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11 - Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11 - Configure OptProf v2 pipeline 16.11 (#8189) - Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12' - Move BAR publish to windows-latest - Merge pull request #8210 from rainersigwald/exp/16.11-build - Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2 - Merge pull request #8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2 ### Testing CI
AR-May
added a commit
that referenced
this pull request
Jan 19, 2023
…o-vs17.4 Backport opt-prof v2 vs17.4 Brings the following changes from the 17.2 branch into 17.4: - [vs16.11] Update dependencies from dotnet/arcade (#7332) - Update dependencies from https://github.com/dotnet/arcade build 20220309.5 - Update dependencies from https://github.com/dotnet/arcade build 20220526.2 - Bump CLI version to match global.json - Bump NuGet version to match - Avoid AssemblyName.KeyPair on .NET (#7660) - Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11 - Merge pull request #7663 from rainersigwald/backport-keypair-elision-16.11 - Configure OptProf v2 pipeline 16.11 (#8189) - Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12' - Move BAR publish to windows-latest - Merge pull request #8210 from rainersigwald/exp/16.11-build - Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2 - Merge pull request #8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2 - Merge remote-tracking branch 'upstream/vs17.0' into exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2 - Merge pull request #8264 from AR-May/exp/AR-May/opt-prof-fix-vs17.0-to-vs17.2 ### Testing CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It throws on .NET 6 and wasn't helpful before anyway:
(from https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assemblyname.keypair?view=net-5.0#remarks):
Fixes #7662
Work item (Internal use):
Summary
Customer Impact
Regression?
Testing
Risk