Add StringIntern for Item and Property Functions. #9024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicated strings from Item and Property Function. Intern these strings to reduce memory usage.
Context
Strings used parsing Item and Property Function are duplicated many times, common offenders are "Contains", "Strings", and "true".
Changes Made
Use the Strings.WeakIntern() tool to cache the strings. Since these are common strings which are shared among projects, use the global String store instead of the project specific store.
Testing
Profiled with the Visual Studio Memory Inspector. This reduced 5-6mb of strings saved in our internal Repro of 200 projects.
Notes
There are still other places here duplicate string exists, this PR focus only on these locations.