Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban XmlReader overloads that take string #9076

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Ban XmlReader overloads that take string #9076

merged 7 commits into from
Aug 2, 2023

Commits on Jul 26, 2023

  1. Ban XmlReader overloads that take string 

    These overloads create a URI from the string and can cause problems with
GB18030 certification, because that URI gets normalized in a way that
doesn't work with all characters. We should instead pass a stream
created from the file, as in dotnet#8931 and dotnet#9028.

Formalize that rule for the whole repo.
    @rainersigwald
    rainersigwald committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8ecb49c View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Add XPathDocument string ctors to banned symbols

    @JanKrivanek
    JanKrivanek committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    bf6fe87 View commit details
    Browse the repository at this point in the history

  2. fix 2 more cases for XmlReader.Create call

    @YuliiaKovalova
    YuliiaKovalova committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    8591300 View commit details
    Browse the repository at this point in the history

  3. Update src/Tasks/XamlTaskFactory/RelationsParser.cs 

    Co-authored-by: Jan Krivanek <jankrivanek@microsoft.com>
    @YuliiaKovalova @JanKrivanek
    YuliiaKovalova and JanKrivanek committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    4ddb752 View commit details
    Browse the repository at this point in the history

  4. fix review comments

    @YuliiaKovalova
    YuliiaKovalova committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d03d3c2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'ban-xmlreader' of https://github.com/rainersigwald/msbuild 

     into ban-xmlreader
    @YuliiaKovalova
    YuliiaKovalova committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d7b6855 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Update src/Tasks/XamlTaskFactory/RelationsParser.cs 

    Co-authored-by: Rainer Sigwald <raines@microsoft.com>
    @YuliiaKovalova @rainersigwald
    YuliiaKovalova and rainersigwald committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    dffb524 View commit details
    Browse the repository at this point in the history