Allow users to influence the value of CreateSatelliteAssembliesDependsOn #9704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
approved these changes
Feb 1, 2024
rainersigwald
approved these changes
Feb 1, 2024
|
@dotnet/kitten when is this ok to merge? |
JanKrivanek
approved these changes
Feb 8, 2024
|
@baronfel - there is no main restriction currently (and we flipped to "team members can merge freely upon 2 internal approvals" recently) - so no need to wait for kitten - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9703
Context
@jaredpar hit this while investigating a Roslyn build process optimization, and it made him sad. We don't want sad @jaredpar.
Changes Made
The property's existing value is prepended to the default dependency target names, like in #4922.
Testing
None
Notes