Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Move the env variables to the separate file #9774

Merged

Conversation

f-alizada
Copy link
Contributor

Context

Continue the documentation of environment variables activity. Step move the already documented env vars into newly created file

Changes Made

Populate file with env vars with already documented variables. Link the file documentation/wiki/MSBuild-Tips-&-Tricks.md to documentation/wiki/MSBuild-Environment-Variables.md

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice initiative! Overall looks good, with couple of comments (after the pre-existing comments are reflected)

documentation/wiki/MSBuild-Environment-Variables.md Outdated Show resolved Hide resolved
documentation/wiki/MSBuild-Environment-Variables.md Outdated Show resolved Hide resolved
JaynieBai added a commit that referenced this pull request Mar 5, 2024
Fixes #9782

Context
Currently workflow runs on every update in the PR and runs the full test on the PR with every update.
However we do not need that when only non source code related changes are made, for instance documentations.
Example of the PR: #9774

Changes Made
Add one pre job with script to check the results of command " git diff --name-only HEAD HEAD~1"

Testing
Test in the draft PR #9812. There are no tests running and tests results uploading
@f-alizada f-alizada merged commit 89b42a4 into dotnet:main Mar 25, 2024
9 checks passed
@f-alizada f-alizada deleted the dev/f-alizada/move-env-variables-to-doc branch June 14, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants