-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Move the env variables to the separate file #9774
Merged
f-alizada
merged 8 commits into
dotnet:main
from
f-alizada:dev/f-alizada/move-env-variables-to-doc
Mar 25, 2024
Merged
[Documentation] Move the env variables to the separate file #9774
f-alizada
merged 8 commits into
dotnet:main
from
f-alizada:dev/f-alizada/move-env-variables-to-doc
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuliiaKovalova
approved these changes
Feb 23, 2024
JanKrivanek
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice initiative! Overall looks good, with couple of comments (after the pre-existing comments are reflected)
JaynieBai
added a commit
that referenced
this pull request
Mar 5, 2024
Fixes #9782 Context Currently workflow runs on every update in the PR and runs the full test on the PR with every update. However we do not need that when only non source code related changes are made, for instance documentations. Example of the PR: #9774 Changes Made Add one pre job with script to check the results of command " git diff --name-only HEAD HEAD~1" Testing Test in the draft PR #9812. There are no tests running and tests results uploading
rainersigwald
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Continue the documentation of environment variables activity. Step move the already documented env vars into newly created file
Changes Made
Populate file with env vars with already documented variables. Link the file documentation/wiki/MSBuild-Tips-&-Tricks.md to documentation/wiki/MSBuild-Environment-Variables.md