Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed string.Format arguments number error #1407

Merged
merged 1 commit into from
Feb 8, 2016
Merged

Fixed string.Format arguments number error #1407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OrleansManager/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private static void UnregisterGrain(string[] args)

var directory = GrainClient.InternalGrainFactory.GetSystemTarget<IRemoteGrainDirectory>(Constants.DirectoryServiceId, silo);

WriteStatus(string.Format("**Calling DeleteGrain({0}, {1}, {2})", silo, grainId));
WriteStatus(string.Format("**Calling DeleteGrain({0}, {1})", silo, grainId));
directory.DeleteGrainAsync(grainId).Wait();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks OK, but I wonder if this method should be changed to an async one or GetAwaiter().GetResult() used instead, as has come up before.

@dVakulen knows this, but included to bring context for larger audience, more information here and here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change can be made in scope of the #1378.

WriteStatus(string.Format("**DeleteGrain finished OK."));
}
Expand All @@ -180,7 +180,7 @@ private static async void LookupGrain(string[] args)

var directory = GrainClient.InternalGrainFactory.GetSystemTarget<IRemoteGrainDirectory>(Constants.DirectoryServiceId, silo);

WriteStatus(string.Format("**Calling LookupGrain({0}, {1}, {2})", silo, grainId));
WriteStatus(string.Format("**Calling LookupGrain({0}, {1})", silo, grainId));
//Tuple<List<Tuple<SiloAddress, ActivationId>>, int> lookupResult = await directory.FullLookUp(grainId, true);
var lookupResult = await directory.LookupAsync(grainId);

Expand Down