Improve support for generic grains with generic state #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the grain type params
ReubenBond
force-pushed
the
fix-generic-grainrefs
branch
from
67bedd9
to
f51c927
Compare
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Feb 14, 2017
…the grain type params (dotnet#2715)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current support for generic grains with generic state assumes that the type parameter to the grain is also the type parameter of the state class.
This PR relaxes that assumption by navigating the concrete grain type's hierarchy until it reaches the
Grain<TState>level and extracting the concrete value ofTState./cc @lwansbrough who reported this issue on Gitter - thank you, Loch!