New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify UseDevelopmentClustering and UseLocalhostClustering #4438
Conversation
I removed ClusterId & ServiceId parameters from the extension methods. That means that there is a single way to specify ClusterId/ServiceId (ignoring legacy config). In my opinion, this is cleaner. It means that users will have to manually specify the value when using
|
…ustering, plus include ServiceId in calls
…Clustering extensions
@benjaminpetit we discussed this for about 40 mins the other day. I thought we had decided to add clusterId + serviceId parameters to |
@ReubenBond let's discuss this live when you are available |
5e6a67f
to
0d79849
Compare
Ok, how does this look, @benjaminpetit? |
) * Try to clarify meaning of UseDevelopmentClustering and UseLocalhostClustering, plus include ServiceId in calls * Remove ClusterId/ServiceId from UseDevelopmentClustering/UseLocalhostClustering extensions * Only configure default ClusterId/ServiceId in UseLocalhostClustering * Add ServiceId & ClusterId to UseLocalhostClustering extensions * fix build
* Try to clarify meaning of UseDevelopmentClustering and UseLocalhostClustering, plus include ServiceId in calls * Remove ClusterId/ServiceId from UseDevelopmentClustering/UseLocalhostClustering extensions * Only configure default ClusterId/ServiceId in UseLocalhostClustering * Add ServiceId & ClusterId to UseLocalhostClustering extensions * fix build
Fixes #4421