Add serviceId parameters to ClientBuilder/ServiceHostBuilder helper methods #4469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take a look at #4438 The middle commit does roughly what you're doing in this PR |
jdom
reviewed
Apr 13, 2018
| { | ||
| return builder.UseStaticClustering(new IPEndPoint(IPAddress.Loopback, gatewayPort)) | ||
| .Configure<ClusterOptions>(options => | ||
| { | ||
| if (!string.IsNullOrWhiteSpace(clusterId)) options.ClusterId = clusterId; | ||
| if (string.IsNullOrWhiteSpace(options.ClusterId)) options.ClusterId = clusterId; |
There was a problem hiding this comment.
You should use PostConfigure instead of Configure for this kind of fallback configuration
|
We can close this since it was included in #4438 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4468
With this PR, test failures from PR #4450 should be gone.
I added check to not override ClusterId/ServiceId set from this methods if they were set explicitely by a call to
Configure<ClusterOptions>before calling them.