Allow placement strategies to skip directory registration #5074
Conversation
| /// Returns a value indicating whether or not this placement strategy requires activations to be registered in | ||
| /// the grain directory. | ||
| /// </summary> | ||
| public virtual bool IsUsingGrainDirectory => true; |
There was a problem hiding this comment.
Will this break backward compatibility with 2.0 and 2/1?
There was a problem hiding this comment.
It will because PlacementStrategy is sent from silo-to-silo when we merge the list of supported grains.
There was a problem hiding this comment.
This isn't serialized, though: it's not backed by a field.
If it was defined as follows, then that would break serialization:
public virtual bool IsUsingGrainDirectory { get; } = true;There was a problem hiding this comment.
That's good. Will it work though for cluster in a (temporary) hybrid state with some silos and clients running a version (2.1) without this change and some a version (2.2) with it?
There was a problem hiding this comment.
I believe so - there's no serialization or behavioral change in this PR until we start adding new placement strategies.
Changes to support placement directors which do not use the grain directory. In short, adds an
IsUsingGrainDirectoryprop toPlacementStrategyand removes some existing special-casing aroundStatelessWorkerPlacementbeing the only placement strategy which can bypass the directory.This is a supporting PR for Service Fabric Stateful Service hosting #5073