Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a code typo in migration guide #5443

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Fix a code typo in migration guide #5443

merged 1 commit into from
Jul 30, 2019

Conversation

centur
Copy link
Contributor

@centur centur commented Mar 14, 2019

Trying to fill some gaps that I found trying to follow migration guides and pages.

Trying to fill some gaps that I found trying to follow migration guides and pages.
@sergeybykov
Copy link
Contributor

@centur Did you mean to keep this as a draft or it is ready to be merged?

@sergeybykov sergeybykov self-assigned this Mar 26, 2019
@centur
Copy link
Contributor Author

centur commented Mar 26, 2019

@sergeybykov draft for now, I'm trying to follow the documentation and saw some more discrepancies in samples so I will try to capture all of them in one PR.

I didn't know that draft on my fork is visible to the main repo maintainers, This is the reason why I didn't put any meaningful description here. I'm getting through quite complicated upgrade process and need to check source code often :(

@sergeybykov
Copy link
Contributor

That's totally fine. No worries then.

@sergeybykov
Copy link
Contributor

@centur Are you still interested in pursuing this?

@centur
Copy link
Contributor Author

centur commented Jul 23, 2019

Good question. The task to migrate from 1.5x to 2.x was not completed as it's quite significant change to our codebase. I have large blocks of changes there and not sure when that PR will be merged and whether it will be merged at all (or will be salvaged for a new migration task).
Also I've moved from Drawboard and don't work with Orleans full-time anymore. I can mark this as open PR so you can merge this small codefix into the main doco, but I'm not making any plans to get back to this in a near future.

@centur centur marked this pull request as ready for review July 23, 2019 01:22
@sergeybykov
Copy link
Contributor

Congrats with your new job!

I can mark this as open PR so you can merge this small codefix into the main doco,

Let's do this.

@centur centur changed the title Changes to the documentation for migration from 1.5.x to 2.x Fix a code typo in migration guide Jul 25, 2019
@sergeybykov sergeybykov merged commit d738ae0 into dotnet:docs Jul 30, 2019
@sergeybykov
Copy link
Contributor

Thank you, @centur!

@centur centur deleted the patch-1 branch July 31, 2019 02:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants