Allow default(ImmutableArray<T>) to be serialized #5587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImmutableArray<T>
is a value type and the default value will throwNullReferenceException
when theLength
property is read. The serializer will read this property to determine how many elements in the array should be written to the stream making it impossible to serializedefault(ImmutableArray<T>)
.This change ensures that
default(ImmutableArray<T>)
can be serialized without throwing aNullReferenceException
. The valuedefault(ImmutableArray<T>)
is indicated by writing-1
as the length of the array to the stream. Note thatImmutableArray<T>.Empty
has a length of0
so the code is able to distinguish between the two values.The deserializer will make a call to
context.RecordObject
. I do not quite understand the purpose of this call and if it is meaningful to do with a value type but I included it in the added code because it was already in the existing code.I have added a test that verifies that
default(ImmutableArray<T>)
can round-trip when serialized.