Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization optimizations for .NET Core 3.1 #6207

Merged
merged 1 commit into from
Jan 1, 2020

Conversation

ReubenBond
Copy link
Member

String serialization:

|   Method |      Mean |  Gen 0 | Allocated |
|--------- |----------:|-------:|----------:|
|   Before |  94.83 ns | 0.0194 |     112 B |
|    After |  68.11 ns |      - |         - |

String deserialization:

|   Method |      Mean |  Gen 0 | Allocated |
|--------- |----------:|-------:|----------:|
|   Before | 134.18 ns | 0.0527 |     304 B |
|    After | 109.08 ns | 0.0334 |     192 B |

@sergeybykov
Copy link
Contributor

It appears to break a bunch of test.

@ReubenBond
Copy link
Member Author

Yep, I will take a look, maybe tomorrow

@ReubenBond
Copy link
Member Author

Ok, it was an edge case - the output buffer needs to have some space or there'll be an exception.

@sergeybykov sergeybykov merged commit 85e8093 into dotnet:master Jan 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants