Simple accumulator to batch grain unregistration in DhtGrainLocator #6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
reviewed
May 5, 2020
| @@ -34,9 +40,64 @@ public async Task<ActivationAddress> Register(ActivationAddress address) | |||
| => (await this.localGrainDirectory.RegisterAsync(address, singleActivation: true)).Address; | |||
|
|
|||
| public Task Unregister(ActivationAddress address, UnregistrationCause cause) | |||
| => this.localGrainDirectory.UnregisterAsync(address, cause); | |||
| { | |||
| var tcs = new TaskCompletionSource<object>(); | |||
There was a problem hiding this comment.
We should add TaskCreationOptions.RunContinuationsAsynchronously - see https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#always-create-taskcompletionsourcet-with-taskcreationoptionsruncontinuationsasynchronously
|
/azp run Azure DevOps - Functional |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ReubenBond
approved these changes
May 6, 2020
benjaminpetit
added a commit
to benjaminpetit/orleans
that referenced
this pull request
Jun 5, 2020
ReubenBond
pushed a commit
that referenced
this pull request
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.