Use TaskCompletionSource.RunContinuationsAsynchronously #6573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeybykov
pushed a commit
that referenced
this pull request
Jun 30, 2020
(cherry picked from commit 38d4afb)
Comment on lines
205
to
207
| //Due to call to Read, this is for sure a IOException and can be thrown out. | ||
| var tcs = new TaskCompletionSource<int>(); | ||
| var tcs = new TaskCompletionSource<int>(TaskCreationOptions.RunContinuationsAsynchronously); | ||
| tcs.SetException(e); |
There was a problem hiding this comment.
This actually makes less sense in this context. You're not in an async context, and the task you are returning is already completed. You should opt for using Task.FromException() and Task. FromCanceled
There was a problem hiding this comment.
Well spotted. The PR was mostly find and replace. When these methods were originally written, FromException and FromCanceled weren't available (neither was Task.CompletedTask), hence the TCS.
Would you be willing to PR your suggestion?
There was a problem hiding this comment.
Yeah, I figured as much :-)
I can do
There was a problem hiding this comment.
Thank you, @icanhasjonas, I appreciate the effort
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/davidfowl/AspNetCoreDiagnosticScenarios/blob/master/AsyncGuidance.md#always-create-taskcompletionsourcet-with-taskcreationoptionsruncontinuationsasynchronously