Avoid registering client observers during shutdown #6879
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/register-client-on-shutdown
branch
from
bc255a9
to
138dc87
Compare
|
@benjaminpetit I fixed the merge conflict. Even though a later PR will obliterate this one by removing ClientObserverRegistrar altogether, I think we can still take this just in case we don't want the ClientDirectory in 3.x |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix here is in
DefaultSiloServices.cs, to ensure the service is registered: TryAdd* is the wrong method for a service which we retrieve multiple implementations of from the the container via 'IEnumerable`.The other changes are just to minorly improve gracefulness.