Fix: Orleans.Hosting.KubernetesHosting: System.MissingMethodException #7346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2, the following error is thrown when using `Orleans.Hosting.KubernetesHosting`: ``` Unhandled exception. System.MissingMethodException: Method not found: 'System.Net.Http.DelegatingHandler k8s.KubernetesClientConfiguration.CreateWatchHandler()'. at Orleans.Hosting.KubernetesHostingExtensions.UseKubernetesHosting(IServiceCollection services, Action`1 configureOptions) ``` This fixes the issue by removing the offending line, which is no longer needed.
|
|
|
Not sure what I can do about those test failures, looks like DynamoDB tests failed, which I haven't touched. |
|
Thanks, Ann, there is something flaky about the DynamoDB tests which I'm not sure about. They're meant to be skipped when run on GitHub. Regardless, it's not a concern for this PR. Thanks for the contribution |
ReubenBond
added
the
Needs: backport
benjaminpetit
pushed a commit
to benjaminpetit/orleans
that referenced
this pull request
Oct 29, 2021
…dotnet#7346) Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2, the following error is thrown when using `Orleans.Hosting.KubernetesHosting`: ``` Unhandled exception. System.MissingMethodException: Method not found: 'System.Net.Http.DelegatingHandler k8s.KubernetesClientConfiguration.CreateWatchHandler()'. at Orleans.Hosting.KubernetesHostingExtensions.UseKubernetesHosting(IServiceCollection services, Action`1 configureOptions) ``` This fixes the issue by removing the offending line, which is no longer needed.
ReubenBond
pushed a commit
that referenced
this pull request
Oct 29, 2021
…7364) * Fix: Orleans.Hosting.KubernetesHosting: System.MissingMethodException (#7346) Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2, the following error is thrown when using `Orleans.Hosting.KubernetesHosting`: ``` Unhandled exception. System.MissingMethodException: Method not found: 'System.Net.Http.DelegatingHandler k8s.KubernetesClientConfiguration.CreateWatchHandler()'. at Orleans.Hosting.KubernetesHostingExtensions.UseKubernetesHosting(IServiceCollection services, Action`1 configureOptions) ``` This fixes the issue by removing the offending line, which is no longer needed. * Fix build for netstandard2.0 Co-authored-by: Ann Wright <highlyunavailable@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2 (e.g. when using KubeOps in conjunction with Orleans in the same app), the following error is thrown when using
Orleans.Hosting.KubernetesHosting:This fixes the issue by removing the offending line, which is no longer needed, and upgrading the referenced Kubernetes client.
Microsoft Reviewers: Open in CodeFlow