Inline watcher #681
Merged
Inline watcher #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
Closed
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
highlyunavailable
added a commit
to highlyunavailable/orleans
that referenced
this pull request
Oct 22, 2021
Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2, the following error is thrown when using `Orleans.Hosting.KubernetesHosting`: ``` Unhandled exception. System.MissingMethodException: Method not found: 'System.Net.Http.DelegatingHandler k8s.KubernetesClientConfiguration.CreateWatchHandler()'. at Orleans.Hosting.KubernetesHostingExtensions.UseKubernetesHosting(IServiceCollection services, Action`1 configureOptions) ``` This fixes the issue by removing the offending line, which is no longer needed.
ReubenBond
pushed a commit
to dotnet/orleans
that referenced
this pull request
Oct 25, 2021
…#7346) Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2, the following error is thrown when using `Orleans.Hosting.KubernetesHosting`: ``` Unhandled exception. System.MissingMethodException: Method not found: 'System.Net.Http.DelegatingHandler k8s.KubernetesClientConfiguration.CreateWatchHandler()'. at Orleans.Hosting.KubernetesHostingExtensions.UseKubernetesHosting(IServiceCollection services, Action`1 configureOptions) ``` This fixes the issue by removing the offending line, which is no longer needed.
benjaminpetit
pushed a commit
to benjaminpetit/orleans
that referenced
this pull request
Oct 29, 2021
…dotnet#7346) Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2, the following error is thrown when using `Orleans.Hosting.KubernetesHosting`: ``` Unhandled exception. System.MissingMethodException: Method not found: 'System.Net.Http.DelegatingHandler k8s.KubernetesClientConfiguration.CreateWatchHandler()'. at Orleans.Hosting.KubernetesHostingExtensions.UseKubernetesHosting(IServiceCollection services, Action`1 configureOptions) ``` This fixes the issue by removing the offending line, which is no longer needed.
ReubenBond
pushed a commit
to dotnet/orleans
that referenced
this pull request
Oct 29, 2021
…7364) * Fix: Orleans.Hosting.KubernetesHosting: System.MissingMethodException (#7346) Due to kubernetes-client/csharp#681 in C# Kubernetes clients newer than 6.0.2, the following error is thrown when using `Orleans.Hosting.KubernetesHosting`: ``` Unhandled exception. System.MissingMethodException: Method not found: 'System.Net.Http.DelegatingHandler k8s.KubernetesClientConfiguration.CreateWatchHandler()'. at Orleans.Hosting.KubernetesHostingExtensions.UseKubernetesHosting(IServiceCollection services, Action`1 configureOptions) ``` This fixes the issue by removing the offending line, which is no longer needed. * Fix build for netstandard2.0 Co-authored-by: Ann Wright <highlyunavailable@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sdk, for really a long, is using a tricky way to
stealstream from response.with controlled generator, the bug was fixed
watch will work with any http client