Branch out DotNet 5 #1484
Branch out DotNet 5 #1484
Conversation
There was a problem hiding this comment.
Overall LGTM, but I think that it would be great to have at least two CI legs that test 6.0 bits (master channel)
I've reported dotnet/runtime#41521 to unblock this PR.
@ooooolivia thank you for working on this!
| '5.0':{ | ||
| 'tfm': 'netcoreapp5.0', | ||
| 'branch': 'release/5.0' | ||
| }, | ||
| 'release/3.1.3xx':{ |
There was a problem hiding this comment.
not related to the goal of this PR, but should we add release/3.1.4xx to the list as well? (we are currently using release/3.1.3xx)
There was a problem hiding this comment.
Thanks for pointing it out! Yes I think we should replace release/3.1.3xx with release/3.1.4xx now as there's no active development on the former.. will include the change in this PR.
There was a problem hiding this comment.
Just realized feeds for release/3.1.4xx are internal feeds different for each build so it cannot simply be hard-coded in NuGet.config. We've discussed it before and the possible solution is to query darc (seems to require more credential setup) to get a new feed each time in our pipeline. @billwert @DrewScoggins Do we have any next step regarding this?
There was a problem hiding this comment.
@ooooolivia FWIW if release/3.1.4xx is problematic we can just keep using the release/3.1.3xx channel. To me, the biggest value of this PR is that it allows me to benchmark 5.0 bits produced from the RC branch, not the 6.0 stuff from master branch.
There was a problem hiding this comment.
agreed. let's do as much as we can and sort the 3.1.4 thing out later.
|
@ooooolivia the feedback I got in dotnet/runtime#41521 tells me that |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ooooolivia
force-pushed
the
branch-out-net5
branch
from
77f6734
to
e4c6225
Compare
No description provided.