Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch out DotNet 5 #1484
Branch out DotNet 5 #1484
Changes from all commits
624bc11
c5be40e
64d79f1
5778dcd
a0101ee
1e013bd
ded8502
17ab7b9
4ab05a0
f27c721
12c3735
e4c6225
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to the goal of this PR, but should we add
release/3.1.4xx
to the list as well? (we are currently usingrelease/3.1.3xx
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing it out! Yes I think we should replace
release/3.1.3xx
withrelease/3.1.4xx
now as there's no active development on the former.. will include the change in this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized feeds for
release/3.1.4xx
are internal feeds different for each build so it cannot simply be hard-coded inNuGet.config
. We've discussed it before and the possible solution is to query darc (seems to require more credential setup) to get a new feed each time in our pipeline. @billwert @DrewScoggins Do we have any next step regarding this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ooooolivia FWIW if
release/3.1.4xx
is problematic we can just keep using therelease/3.1.3xx
channel. To me, the biggest value of this PR is that it allows me to benchmark 5.0 bits produced from the RC branch, not the 6.0 stuff from master branch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed. let's do as much as we can and sort the 3.1.4 thing out later.