Fixes for wasm builds #2320
Merged
Fixes for wasm builds #2320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For wasm builds, we use a custom dotnet populated with the bits from a `runtime` build. And this is passed to bdn via `--cli` argument. The project is built by `benchmarks_ci.py` first, and then run, which then runs builds the project again via BDN, using the dotnet from the `--cli` argument. But this means that the project gets built with the "default" dotnet first, and then the custom one next, which can result in a corrupted build.
This was referenced Mar 17, 2022
LoopedBard3
added
bug
|
Failures are same as mentioned in #2323 (comment) and #2323 (comment) . |
|
LGTM. We should also keep a close eye on this after it gets merged to make sure we don't see any unintended consequences in the runtime repo runs. |
DrewScoggins
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --dotnet-path to the ci scriptsFor wasm builds, we use a custom dotnet populated with the bits from a
runtimebuild. And this is passed to bdn via--cliargument.The project is built by
benchmarks_ci.pyfirst, and then run, whichthen builds the project again via BDN, using the dotnet from the
--cliargument.But this means that the project gets built with the "default" dotnet
first, and then the custom one next, which can result in a corrupted
build. Using
--dotnet-path, same as--cliavoids this.