Surround obsolete X509Certificate2 load in tests with warning disable. #4300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caaavik-msft
approved these changes
Jul 8, 2024
|
Locally tested and necessary for any success so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surround obsolete X509Certificate2 load in tests with warning disable. We started hitting errors when building the microbenchmarks due to the changes made for dotnet/runtime#91763 making their way through to the daily SDK we use to build the benchmarks. Disabling the warning will get the benchmarks running again as we figure out how we want to update the certificate retrieval as the X509CertificateLoader is new and not available on versions < net9.0-preview.7 AFAICT.
First runtime-perf build that hit the issue: https://dev.azure.com/dnceng/internal/_build/results?buildId=2490580&view=results