Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surround obsolete X509Certificate2 load in tests with warning disable. #4300

Merged
merged 1 commit into from
Jul 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ private static X509Certificate2 GetCertificate(string certificateFileName)
{
try
{
#pragma warning disable SYSLIB0057 // Warning disabled per https://github.com/dotnet/docs/issues/41662, TODO: Update to use X509CertificateLoader.LoadPkcs12FromFile we are able to use it (will need to version block with this regardless).
return new X509Certificate2(
File.ReadAllBytes(
Path.Combine(
Expand All @@ -36,6 +37,7 @@ private static X509Certificate2 GetCertificate(string certificateFileName)
certificateFileName)),
CertificatePassword,
X509KeyStorageFlags.DefaultKeySet);
#pragma warning restore SYSLIB0057
}
catch (Exception)
{
Expand Down
Loading