Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: profiling local CoreFX build using VTune #849

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

adamsitnik
Copy link
Member

@@ -18,6 +18,12 @@
- [Analyzing the Results](#Analyzing-the-Results)
- [Viewing Source Code](#Viewing-Source-Code)
- [Identifying Regressions](#Identifying-Regressions)
- [VTune](#VTune)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a separate section or at least briefly call out AMD uProf which is the similar program for AMD machines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, we should definitely have AMD uProf section

@tannergooding do I remember correctly from your presentation that I can run AMD uProf on Intel machine? So I should be able to create similar docs myself without need to access AMD machine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they should work for the most part (VTune on AMD and uProf on Intel); but various options won't be supported and you may not get as accurate traces/etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it isn't working well enough, I can cover the same example for AMD uProf and modify the doc after this PR is merged (just create an issue an assign it to me)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding excellent! Since I am now working on the PerfCollect and dotnet trace doc I am going to create a separate issue and assign you. Thanks!

@adamsitnik adamsitnik merged commit 26f4a75 into dotnet:master Sep 3, 2019
@adamsitnik adamsitnik deleted the vtune branch September 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants