Don't require analyzers to be in evaluation data #5830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
added
the
Feature-Dependency-Node
davidwengier
approved these changes
Jan 24, 2020
|
Analyzers can come from evaluation, via the |
|
Analyzers that come from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5418.
The dependency node receives both evaluation (unresolved) data and design-time build (resolved) data. Both sources provide data about the same items and must be correlated and combined.
A while ago the dependency node changed to disallow adding items to the tree that appear only in design-time build results. This broke the Analyzers node as analyzers are not available during evaluation (see #4782).
This change allows specific rules to opt out of the restriction, doing so only for analyzer items.