Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: Fix PriorityQueue to not share a item ordering helper index #507

Merged
merged 1 commit into from
May 26, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions Rx.NET/Source/src/System.Reactive/Internal/PriorityQueue.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ namespace System.Reactive
{
internal sealed class PriorityQueue<T> where T : IComparable<T>
{
private static long _count = long.MinValue;
private long _count = long.MinValue;
private IndexedItem[] _items;
private int _size;

Expand Down Expand Up @@ -125,7 +125,7 @@ public void Enqueue(T item)
}

var index = _size++;
_items[index] = new IndexedItem { Value = item, Id = Interlocked.Increment(ref _count) };
_items[index] = new IndexedItem { Value = item, Id = ++_count };
Percolate(index);
}

Expand Down